Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cluster-reflector] Allow filtering out "self" (e.g. if user moves/"pivot"s their CAPI cluster) #3739

Open
foot opened this issue Dec 19, 2023 · 0 comments
Assignees

Comments

@foot
Copy link
Collaborator

foot commented Dec 19, 2023

General solution

kind: ACD
spec:
  exclude: ["my-capi-cluster"] # if there's a eks/aks cluster.
  exclude: ["<capi-UID>"] # if there's a capi

Specific to CAPI:

kind: ACD
spec:
  capi:
    clusterID: <uid of the capi object that is the hosting cluster>

^ ClusterID here is a bit awkward to look up and manage and debug (its a UID).

kind: ACD
spec:
  capi:
    currentClusterName: 
    managementClusterName: my-cluster # <--- this one, CAPI using the terminology
    selfClusterName:

Decision

Lets go w/ the spec.capi.managementClusterName solution, it aligns w/ the automatic solution we have eks/aks, and then we can always identify the "management" cluster for all providers, which may come in handy in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants