Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time Travel: keep active node details panels up-to-date #2807

Merged
merged 3 commits into from
Aug 14, 2017

Conversation

fbarl
Copy link
Contributor

@fbarl fbarl commented Aug 10, 2017

Resolves #2776 and implements nicer UX transitions for node details panels when time travelling.

Changes
  • Introduces a semitransparent layer in node details panel similar to the one for nodes layout that is activated whenever updating the panel with the data at a different timestamp.
  • Each node details panel now has a timestamp attached to it that enables smarter updates.
  • Implements a lightweight solution from Time Travel: details panels in the background don't update with timestamp #2776, which triggers the node details panel update every time the top panel is closed and a background one pops into the focus, to make sure the displayed data is always consistent with the timestamp.

@fbarl fbarl self-assigned this Aug 10, 2017
@fbarl fbarl force-pushed the keep-node-details-up-to-date-when-time-travelling branch from c1b8096 to 596885e Compare August 11, 2017 11:26
@fbarl fbarl changed the title [WIP] Time Travel: keep active node details panels up-to-date Time Travel: keep active node details panels up-to-date Aug 11, 2017
@fbarl fbarl requested a review from jpellizzari August 11, 2017 14:37
@fbarl fbarl merged commit ad2e530 into master Aug 14, 2017
@fbarl fbarl deleted the keep-node-details-up-to-date-when-time-travelling branch October 20, 2017 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time Travel: details panels in the background don't update with timestamp
2 participants