-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test multiple versions of k8s #291
Conversation
- First go, use even more yaml anchor helpers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
19 checks successful
! 😱
looks great to me ⭐ :)
I've been toying with the idea of generating travis/circle CI files from js/ts and jk
to go beyond anchors, but it seems anchors can be made quite readable :)
Yes! That was plan B when anchors obviously failed, but they worked okay in the end. |
This is awesome! Two niggles
|
Will fix
I tested out the "squash and merge" feature of GitHub for the first time which has made a history that looks like this now:
E.g. It created a new squashed commit on master rather than a merge commit. I'll avoid that in the future as its a bit confusing. |
I would stay away from "squash and merge" and be more selective. Squashing all commits into one is rarely the right level of granularity. |
Fixes #288