Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect up the event recorder #23

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Connect up the event recorder #23

merged 1 commit into from
Nov 14, 2023

Conversation

foot
Copy link
Collaborator

@foot foot commented Nov 13, 2023

Follow up on #19

  • So that we fire events when the controller is deployed

- So that we fire events when the controller is deployed
@foot foot requested a review from sarataha November 13, 2023 14:31
Copy link
Contributor

@sarataha sarataha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@foot foot merged commit b5b83a7 into main Nov 14, 2023
3 checks passed
@foot foot deleted the connect-up-event-recorder branch November 14, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants