Cluster #12
Merged
Cluster #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigkevmcd
force-pushed
the
cluster-id
branch
2 times, most recently
from
da292f7
to
d4dfe9d
Compare
bigkevmcd
force-pushed
the
cluster-id
branch
2 times, most recently
from
3488dd8
to
1e7bd3e
Compare
Extract cluster ID from ConfigMap and the returned list of clusters.
foot
reviewed
Oct 24, 2023
|
|
||
| id := fmt.Sprintf("/subscriptions/%s/resourcegroups/%s/providers/Microsoft.ContainerService/managedClusters/%s", | ||
| keys["AZURE_SUBSCRIPTION_ID"], keys["AZURE_RESOURCE_GROUP"], | ||
| keys["AZURE_RESOURCE_NAME"]) |
There was a problem hiding this comment.
Should we bail if some of the values here are missing? ... or maybe just log something?
Worst case we accidentally load the current cluster. Which is not that awful.
There was a problem hiding this comment.
Good question, this is designed so that if the ConfigMap doesn't exist, it will basically match an incomplete string, that is unlikely to match the ID that comes from the ProviderCluster.
foot
reviewed
Oct 24, 2023
| func (p *AzureProvider) ClusterID(ctx context.Context, kubeClient client.Reader) (string, error) { | ||
| configMap := &corev1.ConfigMap{} | ||
| if err := kubeClient.Get(ctx, client.ObjectKey{Name: "extension-manager-config", Namespace: "kube-system"}, configMap); err != nil { | ||
| return "", client.IgnoreNotFound(err) |
There was a problem hiding this comment.
Right.. if its missing we don't bail either. I'm not so stressed for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for determining a Cluster ID and getting the ID from the list of clusters.
This is then used to avoid reflecting the "current" cluster (the cluster the controller is running in) as a GitopsCluster which would lead to cluster duplication.