lack of config

Author: davidleonm

package-lock.json

@@ -27,6 +27,7 @@
     "@opentelemetry/instrumentation-document-load": "^0.48.0",
     "@opentelemetry/instrumentation-user-interaction": "^0.48.0",
     "@opentelemetry/instrumentation-xml-http-request": "^0.203.0",
+    "@opentelemetry/opentelemetry-browser-detector": "^0.203.0",
     "@opentelemetry/resources": "^2.0.1",
     "@opentelemetry/sdk-trace-web": "^2.0.1",
     "@opentelemetry/semantic-conventions": "^1.36.0",

package.json

@@ -61,12 +61,12 @@ export class Config {
     }
 
     this.otlp = {
-      rootUrl: process.env.OTEL_EXPORTER_OTLP_ENDPOINT || 'http://localhost:4318',
-      debugInConsole: process.env.OTEL_DEBUG_IN_CONSOLE === 'true',
+      rootUrl: 'http://localhost:4318',
+      debugInConsole: 'true' === 'true',
       attrs: {
         serviceName: 'wsp-web-ui',
-        serviceVersion: process.env.OTEL_SERVICE_VERSION || '0.0.1',
-        deploymentEnvironment: process.env.OTEL_DEPLOYMENT_ENVIRONMENT || 'localhost',
+        serviceVersion: '0.0.1',
+        deploymentEnvironment: 'localhost',
       },
     }
   }

src/config/config.ts

@@ -5,23 +5,23 @@ import { DocumentLoadInstrumentation } from '@opentelemetry/instrumentation-docu
 import { UserInteractionInstrumentation } from '@opentelemetry/instrumentation-user-interaction'
 import { XMLHttpRequestInstrumentation } from '@opentelemetry/instrumentation-xml-http-request'
 import { GlobalConfig } from './config/config.ts'
-import { resourceFromAttributes } from '@opentelemetry/resources'
+import { detectResources, resourceFromAttributes } from '@opentelemetry/resources'
 import { ATTR_SERVICE_NAME, ATTR_SERVICE_VERSION, SemanticResourceAttributes } from '@opentelemetry/semantic-conventions'
 import { OTLPTraceExporter } from '@opentelemetry/exporter-trace-otlp-http'
+import { browserDetector } from '@opentelemetry/opentelemetry-browser-detector'
 
 /*
 Useful links:
   https://opentelemetry.io/docs/languages/js/getting-started/browser/
   https://opentelemetry.io/docs/concepts/semantic-conventions/
 */
-
 const provider = new WebTracerProvider({
   spanProcessors: getProcessors(),
   resource: resourceFromAttributes({
     [ATTR_SERVICE_NAME]: GlobalConfig.otlp.attrs.serviceName,
     [ATTR_SERVICE_VERSION]: GlobalConfig.otlp.attrs.serviceVersion,
     [SemanticResourceAttributes.DEPLOYMENT_ENVIRONMENT]: GlobalConfig.otlp.attrs.deploymentEnvironment,
-  }),
+  }).merge(detectResources({ detectors: [browserDetector] })),
 })
 
 provider.register({
@@ -44,65 +44,3 @@ function getProcessors(): SpanProcessor[] {
 registerInstrumentations({
   instrumentations: [new UserInteractionInstrumentation(), new XMLHttpRequestInstrumentation(), new DocumentLoadInstrumentation()],
 })
-
-/*export const otelSDK = new NodeSDK({
-  spanProcessors: getProcessors(),
-  metricReader: getMetricReader(),
-  resource: resourceFromAttributes({
-    [ATTR_SERVICE_NAME]: GlobalConfig.otlp.attrs.serviceName,
-    [ATTR_SERVICE_VERSION]: GlobalConfig.otlp.attrs.serviceVersion,
-    [SemanticResourceAttributes.DEPLOYMENT_ENVIRONMENT]: GlobalConfig.otlp.attrs.deploymentEnvironment,
-  }),
-  instrumentations: [new SocketIoInstrumentation(), new NestInstrumentation(), new PinoInstrumentation()],
-})
-
-function getProcessors(): SpanProcessor[] {
-  return [
-    new BatchSpanProcessor(
-      GlobalConfig.otlp.debugInConsole
-        ? new ConsoleSpanExporter()
-        : new OTLPTraceExporter({
-            url: `${GlobalConfig.otlp.rootUrl}/v1/traces`,
-            headers: {},
-          })
-    ),
-  ]
-}
-
-function getMetricReader(): IMetricReader {
-  return new PeriodicExportingMetricReader({
-    exporter: GlobalConfig.otlp.debugInConsole
-      ? new ConsoleMetricExporter()
-      : new OTLPMetricExporter({
-          url: `${GlobalConfig.otlp.rootUrl}/v1/metrics`,
-        }),
-  })
-}
-
-let hostMetricsSDK: HostMetrics | undefined
-export function getHostMetricsSDK(): HostMetrics {
-  if (hostMetricsSDK) {
-    return hostMetricsSDK
-  }
-
-  hostMetricsSDK = new HostMetrics({
-    meterProvider: metrics.getMeterProvider(),
-  })
-  return hostMetricsSDK
-}
-
-function shutdownSDK(): void {
-  otelSDK
-    .shutdown()
-    .then(() => {
-      console.log('OpenTelemetry SDK shutdown successfully.')
-      process.exit(0)
-    })
-    .catch((error) => {
-      console.error('Error shutting down OpenTelemetry SDK: ', error)
-      process.exit(1)
-    })
-}
-
-process.on('SIGTERM', (): void => shutdownSDK())
-process.on('SIGINT', (): void => shutdownSDK())*/