Skip to content

Commit 6206b36

Browse files
committed
feat: added cases for whitespace and removed the isRequired cases
1 parent 4b50b61 commit 6206b36

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

test/unit/rules.test.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -448,12 +448,18 @@ describe('number', () => {
448448
describe('required', () => {
449449
it('fails on empty string', async () => expect(await rules.required({ value: '' })).toBe(false))
450450

451+
it('fails with only whitespace as value when second argument is "trim"', async () => expect(await rules.required({ value: ' ' }, 'trim')).toBe(false))
452+
451453
it('fails on empty array', async () => expect(await rules.required({ value: [] })).toBe(false))
452454

453455
it('fails on empty object', async () => expect(await rules.required({ value: {} })).toBe(false))
454456

455457
it('fails on null', async () => expect(await rules.required({ value: null })).toBe(false))
456458

459+
it('passes with only whitespace as value', async () => expect(await rules.required({ value: ' ' })).toBe(true))
460+
461+
it('passes with only whitespace as value when second argument is not "trim"', async () => expect(await rules.required({ value: ' ' }, 'pre')).toBe(true))
462+
457463
it('passes with the number zero', async () => expect(await rules.required({ value: 0 })).toBe(true))
458464

459465
it('passes with the boolean false', async () => expect(await rules.required({ value: false })).toBe(true))
@@ -462,10 +468,6 @@ describe('required', () => {
462468

463469
it('passes with a non empty object', async () => expect(await rules.required({ value: { a: 'b' } })).toBe(true))
464470

465-
it('passes with empty value if second argument is false', async () => expect(await rules.required({ value: '' }, false)).toBe(true))
466-
467-
it('passes with empty value if second argument is false string', async () => expect(await rules.required({ value: '' }, 'false')).toBe(true))
468-
469471
it('passes with FileUpload', async () => expect(await rules.required({ value: new FileUpload({ files: [{ name: 'j.png' }] }) })).toBe(true))
470472

471473
it('fails with empty FileUpload', async () => expect(await rules.required({ value: new FileUpload({ files: [] }) })).toBe(false))

0 commit comments

Comments
 (0)