fix listeners re-adding with share buttons update #28
Conversation
| var iehandler = function () { | ||
| handler.call(el); | ||
| }; | ||
| var cachedRef = el.getAttribute('data-sharebtn-ref') |
There was a problem hiding this comment.
Great idea to store refs, but I think it will be more clear when this logic will be split as init (add listeners) and deinit/dispose (remove listeners, clear states), after that update() can compose these methods
There was a problem hiding this comment.
Yeah, but actually update use this.i() to reinit .share-btn expected data and actions. Splitting the process with a deinit function address the challenge to loop links a twice to add and remove listeners. However it can be more convenient to process removeEventListener and then addEventListener in prepareLink step. This like you suggest, to be more clear on that logic.
|
Okay
Okay will do it. |
|
Close this PR in favor of this PR #30 addressing requested changes |
Previous added listeners to share buttons are re-added twice or multiple time when execute
ShareButtons.update().In browsers, if
data-urlordata-titleordata-deschave been changed before callingShareButtons.update(), the changes will not be considered because the previous added listeners with previous data value on share buttons will be executed on click event before the new added listeners afterShareButtons.update().This pull request aims to fix that.