Skip to content

Email share has title twice in the subject line #19

Closed
@farmerpaul

Description

@farmerpaul

When you click an email share button, the email that's composed has a subject line with the page title displayed twice in a row, separated by a slash.

I'm not sure what the intention was for positions {0} and {1} in the MAIL_LINK_FORMAT string, but the code that generates the email link inserts URL-escaped title with a slash appended to it for {0}, and immediately follows it with the non-escaped titleDef. This results in the title appearing twice in the subject line. I'm surprised nobody else has noticed this?

Seems to me that MAIL_LINK_FORMAT should instead just have one substitution for the subject line {0}, being title. Thoughts?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions