Skip to content

Commit c14bc5e

Browse files
committed
fix test #1
Signed-off-by: wangbaiping(wbpcode) <wbphub@gmail.com>
1 parent 921e39d commit c14bc5e

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

test/extensions/common/tap/admin_test.cc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -329,6 +329,8 @@ TEST_F(AdminHandlerTest, CloseMidStream) {
329329
PerTapSinkHandlePtr sinkHandle =
330330
handler_->createPerTapSinkHandle(0, ProtoOutputSink::OutputSinkTypeCase::kStreamingAdmin);
331331

332+
EXPECT_EQ(nullptr, attachedRequest()->traceBuffer());
333+
332334
EXPECT_CALL(main_thread_dispatcher_, post(_)).Times(2);
333335
main_thread_dispatcher_.post([this] { attachedRequest().reset(); });
334336
sinkHandle->submitTrace(makeTraceWrapper(), format);

test/per_file_coverage.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ declare -a KNOWN_LOW_COVERAGE=(
2424
"source/common/watchdog:58.6" # Death tests don't report LCOV
2525
"source/exe:94.2" # increased by #32346, need coverage for terminate_handler and hot restart failures
2626
"source/extensions/common/proxy_protocol:93.8" # Adjusted for security patch
27-
"source/extensions/common/tap:94.6"
27+
"source/extensions/common/tap:94.4"
2828
"source/extensions/common/wasm:95.3" # flaky: be careful adjusting
2929
"source/extensions/common/wasm/ext:92.0"
3030
"source/extensions/filters/common/fault:94.5"

0 commit comments

Comments
 (0)