fix: newCleanup judgement

waynecz · web-flow · commit 172b93b85bb8 · 2019-03-11T12:21:33.000+08:00
diff --git a/src/index.ts b/src/index.ts
@@ -85,7 +85,7 @@ export class Component {
       isFunction(cleanup) && cleanup!()
 
       const newCleanup = callback(this.base)
-      if (cleanup) {
+      if (newCleanup) {
         __ReactMemoizedEffects[cursor].cleanup = newCleanup
       }
     })

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ export class Component {`
`85`	`85`	`isFunction(cleanup) && cleanup!()`
`86`	`86`
`87`	`87`	`const newCleanup = callback(this.base)`
`88`		`- if (cleanup) {`
	`88`	`+ if (newCleanup) {`
`89`	`89`	`__ReactMemoizedEffects[cursor].cleanup = newCleanup`
`90`	`90`	`}`
`91`	`91`	`})`