Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sort keys for complex IDs #20

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

sort keys for complex IDs #20

wants to merge 5 commits into from

Conversation

deweyjose
Copy link
Contributor

@deweyjose deweyjose commented Dec 22, 2022 •
edited
Loading

Description

  • additional unit test for IDs comprised of entities with complex object structures.
  • sort entity keys for complex IDs
  • remove base64 encoding within core FROID algorithms. Users must add this to their Codec implementation.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the
    contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@deweyjose deweyjose requested a review from a team as a code owner December 22, 2022 03:25
@deweyjose deweyjose changed the title additional test for complex IDs sort keys for complex IDs Dec 22, 2022
mjfaga
mjfaga approved these changes Dec 22, 2022
View reviewed changes
pom.xml
@@ -4,7 +4,7 @@

<groupId>com.wayfair</groupId>
<artifactId>java-froid</artifactId>
<version>0.1.1</version>
<version>0.2.0</version>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would patch, not minor. this is to fix a deterministic issue with the existing implementation.

@github-actions
Copy link

Automatically marking pull request as stale due to lack of activity

@github-actions github-actions bot added the stale label Feb 26, 2023
@github-actions
Copy link

Automatically closing this pull request as stale

@github-actions github-actions bot closed this Mar 12, 2023
@mjfaga mjfaga reopened this Mar 12, 2023
@github-actions github-actions bot removed the stale label Mar 19, 2023
@github-actions
Copy link

Automatically marking pull request as stale due to lack of activity

@github-actions github-actions bot added the stale label May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjfaga mjfaga mjfaga approved these changes

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deweyjose @mjfaga