Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common interface for common attributes #14

Closed
deweyjose opened this issue Oct 10, 2022 · 0 comments · Fixed by #18
Closed

common interface for common attributes #14

deweyjose opened this issue Oct 10, 2022 · 0 comments · Fixed by #18
Labels
enhancement New feature or request

Comments

@deweyjose
Copy link
Contributor

Problem Statement

EntitiesResponse and EntityObjectResponse share a common set of attributes, getter/setters for error and extensions.

Testing the result of handleFroidRequest is more complex than it needs to be. use-case - logging errors.

Proposed Solution

Define a common interface that provides accessors for errors and exentions.

Alternatives Considered

Please briefly describe which alternatives, if any, have been considered,
including merits of alternate approaches and tradeoffs being made.

Additional Context

Please provide any other information that may be relevant.

@mjfaga mjfaga added the enhancement New feature or request label Oct 10, 2022
@deweyjose deweyjose mentioned this issue Dec 5, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants