Skip to content

Commit 7135f9e

Browse files
committed
More tweaks for 3.2 compat
Test suite now passes
1 parent 9c491f0 commit 7135f9e

File tree

2 files changed

+19
-14
lines changed

2 files changed

+19
-14
lines changed

ipaddr.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,9 @@
2424

2525
__version__ = '2.1.11-py3.2'
2626

27+
long = int
28+
xrange = range
29+
2730
import struct
2831

2932
IPV4LENGTH = 32

ipaddr_test.py

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717

1818
"""Unittest for ipaddr module."""
1919

20+
long = int
21+
xrange = range
2022

2123
import unittest
2224
import time
@@ -274,7 +276,7 @@ def testGetIp(self):
274276
'2001:658:22a:cafe:200::1')
275277

276278
def testGetNetmask(self):
277-
self.assertEqual(int(self.ipv4.netmask), 4294967040L)
279+
self.assertEqual(int(self.ipv4.netmask), 4294967040)
278280
self.assertEqual(str(self.ipv4.netmask), '255.255.255.0')
279281
self.assertEqual(str(self.ipv4_hostmask.netmask), '255.0.0.0')
280282
self.assertEqual(int(self.ipv6.netmask),
@@ -291,7 +293,7 @@ def testZeroNetmask(self):
291293
self.assertEqual(ipv6_zero_netmask._prefix_from_prefix_string('0'), 0)
292294

293295
def testGetBroadcast(self):
294-
self.assertEqual(int(self.ipv4.broadcast), 16909311L)
296+
self.assertEqual(int(self.ipv4.broadcast), 16909311)
295297
self.assertEqual(str(self.ipv4.broadcast), '1.2.3.255')
296298

297299
self.assertEqual(int(self.ipv6.broadcast),
@@ -1158,24 +1160,24 @@ def testWithStar(self):
11581160

11591161
def testNetworkElementCaching(self):
11601162
# V4 - make sure we're empty
1161-
self.assertFalse(self.ipv4._cache.has_key('network'))
1162-
self.assertFalse(self.ipv4._cache.has_key('broadcast'))
1163-
self.assertFalse(self.ipv4._cache.has_key('hostmask'))
1163+
self.assertFalse('network' in self.ipv4._cache)
1164+
self.assertFalse('broadcast' in self.ipv4._cache)
1165+
self.assertFalse('hostmask' in self.ipv4._cache)
11641166

11651167
# V4 - populate and test
11661168
self.assertEqual(self.ipv4.network, ipaddr.IPv4Address('1.2.3.0'))
11671169
self.assertEqual(self.ipv4.broadcast, ipaddr.IPv4Address('1.2.3.255'))
11681170
self.assertEqual(self.ipv4.hostmask, ipaddr.IPv4Address('0.0.0.255'))
11691171

11701172
# V4 - check we're cached
1171-
self.assertTrue(self.ipv4._cache.has_key('network'))
1172-
self.assertTrue(self.ipv4._cache.has_key('broadcast'))
1173-
self.assertTrue(self.ipv4._cache.has_key('hostmask'))
1173+
self.assertTrue('network' in self.ipv4._cache)
1174+
self.assertTrue('broadcast' in self.ipv4._cache)
1175+
self.assertTrue('hostmask' in self.ipv4._cache)
11741176

11751177
# V6 - make sure we're empty
1176-
self.assertFalse(self.ipv6._cache.has_key('network'))
1177-
self.assertFalse(self.ipv6._cache.has_key('broadcast'))
1178-
self.assertFalse(self.ipv6._cache.has_key('hostmask'))
1178+
self.assertFalse('network' in self.ipv6._cache)
1179+
self.assertFalse('broadcast' in self.ipv6._cache)
1180+
self.assertFalse('hostmask' in self.ipv6._cache)
11791181

11801182
# V6 - populate and test
11811183
self.assertEqual(self.ipv6.network,
@@ -1186,9 +1188,9 @@ def testNetworkElementCaching(self):
11861188
ipaddr.IPv6Address('::ffff:ffff:ffff:ffff'))
11871189

11881190
# V6 - check we're cached
1189-
self.assertTrue(self.ipv6._cache.has_key('network'))
1190-
self.assertTrue(self.ipv6._cache.has_key('broadcast'))
1191-
self.assertTrue(self.ipv6._cache.has_key('hostmask'))
1191+
self.assertTrue('network' in self.ipv6._cache)
1192+
self.assertTrue('broadcast' in self.ipv6._cache)
1193+
self.assertTrue('hostmask' in self.ipv6._cache)
11921194

11931195
def testTeredo(self):
11941196
# stolen from wikipedia

0 commit comments

Comments
 (0)