Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider suggesting installing wasm-pack when rawBuild crashed #7

Closed
rail-rain opened this issue Nov 6, 2018 · 3 comments
Closed

Comments

@rail-rain
Copy link

rail-rain commented Nov 6, 2018

wasmPackBuild sometime fixes rawBuild's crashing but users can't know it unless they inspect source code.

rawBuild crashes when outputs of cargo metadata exceed child process's maxBuffer and users use workspace(wasm-pack will support it.)

@catsigma
Copy link
Collaborator

catsigma commented Nov 6, 2018

Thanks for this issue.

I've pushed a fix containing the tip of wasm-pack suggestion.

Could you please try it to see if it can catch all the fails mentioned above?

https://github.com/catsigma/parcel-plugin-wasm.rs/tree/rawbuild-fail-tip

@rail-rain
Copy link
Author

Thank you for quick responding.

it catches exceeding maxBuffer. But I'm so sorry, rawBuild supports workspace. Crashing in workspace is caused by other function. However, I think this issue ready to close.

@catsigma
Copy link
Collaborator

catsigma commented Nov 8, 2018

fixed @ 1.2.6

@catsigma catsigma closed this as completed Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants