Merge pull request rails#43904 from TooManyBees/apply-migration-exception-to-7-1

Apply migration if_exists exception only on migrations >= v7.1

Author: eileencodes

activerecord/lib/active_record/migration/compatibility.rb

@@ -33,6 +33,35 @@ def self.find(version)
       V7_1 = Current
 
       class V7_0 < V7_1
+        module TableDefinition
+          private
+            def raise_on_if_exist_options(options)
+            end
+        end
+
+        def create_table(table_name, **options)
+          if block_given?
+            super { |t| yield compatible_table_definition(t) }
+          else
+            super
+          end
+        end
+
+        def change_table(table_name, **options)
+          if block_given?
+            super { |t| yield compatible_table_definition(t) }
+          else
+            super
+          end
+        end
+
+        private
+          def compatible_table_definition(t)
+            class << t
+              prepend TableDefinition
+            end
+            t
+          end
       end
 
       class V6_1 < V7_0
@@ -119,6 +148,10 @@ def column(name, type, index: nil, **options)
             options[:precision] ||= nil
             super
           end
+
+          private
+            def raise_on_if_exist_options(options)
+            end
         end
 
         def create_table(table_name, **options)
@@ -171,6 +204,10 @@ def column(name, type, index: nil, **options)
             options[:precision] ||= nil
             super
           end
+
+          private
+            def raise_on_if_exist_options(options)
+            end
         end
 
         module CommandRecorder
@@ -265,6 +302,10 @@ def references(*args, **options)
             super(*args, type: :integer, **options)
           end
           alias :belongs_to :references
+
+          private
+            def raise_on_if_exist_options(options)
+            end
         end
 
         def create_table(table_name, **options)
@@ -331,6 +372,10 @@ def timestamps(**options)
             options[:null] = true if options[:null].nil?
             super
           end
+
+          private
+            def raise_on_if_exist_options(options)
+            end
         end
 
         def add_reference(table_name, ref_name, **options)

activerecord/test/cases/migration/compatibility_test.rb

@@ -520,7 +520,7 @@ def migrate(x)
       end
 
       def test_change_table_allows_if_exists_option_on_6_1
-        migration = Class.new(ActiveRecord::Migration[6.1]) {
+        migration = Class.new(ActiveRecord::Migration[7.0]) {
           def migrate(x)
             change_table(:testings) do |t|
               t.remove :foo, if_exists: true