Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library requires tools:replace in client AndroidManifest.xml #15

Open
AndyG opened this issue Oct 30, 2017 · 0 comments
Open

Library requires tools:replace in client AndroidManifest.xml #15

AndyG opened this issue Oct 30, 2017 · 0 comments

Comments

@AndyG
Copy link

AndyG commented Oct 30, 2017

First off, thanks for the wonderful library. Made certain requirements in my application a breeze!

Unfortunately, currently clients using this library must include tools:replace="allowBackup,android:label" for their apps to compile. This is due to the example library's manifest including

https://github.com/wasabeef/fresco-processors/blob/master/example/src/main/AndroidManifest.xml#L10

and

https://github.com/wasabeef/fresco-processors/blob/master/example/src/main/AndroidManifest.xml#L17

Please remove the samples from the published artifact so we won't have to manually override these attributes in our app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant