Skip to content

Commit 5f2d371

Browse files
committed
pdfkit/pdfkit: Improved stdout/stderr decoding (errors handling)
1 parent 5b81171 commit 5f2d371

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

pdfkit/pdfkit.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -144,10 +144,7 @@ def to_pdf(self, path=None):
144144

145145
exit_code = result.returncode
146146
if exit_code != 0:
147-
try:
148-
stderr = stderr.decode('utf-8')
149-
except UnicodeDecodeError:
150-
stderr = ''
147+
stderr = stderr.decode('utf-8', errors='replace')
151148

152149
if 'cannot connect to X server' in stderr:
153150
raise IOError('%s\n'
@@ -164,7 +161,7 @@ def to_pdf(self, path=None):
164161
# Since wkhtmltopdf sends its output to stderr we will capture it
165162
# and properly send to stdout
166163
if '--quiet' not in args:
167-
sys.stdout.write(stderr.decode('utf-8'))
164+
sys.stdout.write(stderr.decode('utf-8', errors='replace'))
168165

169166
if not path:
170167
return stdout

0 commit comments

Comments
 (0)