Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TaskRow Component Should be Split #73

Open
pr1sm opened this issue Sep 10, 2018 · 3 comments
Open

TaskRow Component Should be Split #73

pr1sm opened this issue Sep 10, 2018 · 3 comments
Labels
area:frontend Related to Nebula's Frontend Electron app priority:low Issues that are low priority don't need to be solved right away type:tech-debt Issues related to adjusting underlying implementation details without affecting the end product

Comments

@pr1sm
Copy link
Collaborator

pr1sm commented Sep 10, 2018

Is your feature request related to a problem? Please describe.
The TaskRow Component is getting more complicated due to the rendering of both the row and the optional edit menu.

Describe the solution you'd like
The TaskRow should contain only the code associated with the Row component and a new TaskEdit component should be created to encapsulate the Edit Menu. The TaskRow would depend on the TaskEdit Component for the menu when that row is selected.

@pr1sm pr1sm added area:frontend Related to Nebula's Frontend Electron app type:tech-debt Issues related to adjusting underlying implementation details without affecting the end product labels Sep 10, 2018
@walmat
Copy link
Owner

walmat commented Sep 10, 2018

I agree! It would be nice to keep code clean as we move forward. Maybe we can do this once we have an initial launch though and only focus on stuff that would be an immediate need for launch? Let me know what you think!

@pr1sm
Copy link
Collaborator Author

pr1sm commented Sep 10, 2018

Yep! That's what I was thinking, I just wanted to get the issue noted while it was on my mind. There are a couple of issues I've already created that use the tech-debt label. These are all issues that are lower priority and not required for our launch.

Most of these issues are also really easy, so we can also knock them out if we have a spare hour or want to take a quick break from a larger issue.

@walmat
Copy link
Owner

walmat commented Sep 10, 2018

Yep! That's what I was thinking, I just wanted to get the issue noted while it was on my mind. There are a couple of issues I've already created that use the tech-debt label. These are all issues that are lower priority and not required for our launch. ...

@pr1sm ah gotcha! Yeah that makes sense. Sorry!

Sent with GitHawk

@pr1sm pr1sm added the priority:low Issues that are low priority don't need to be solved right away label Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend Related to Nebula's Frontend Electron app priority:low Issues that are low priority don't need to be solved right away type:tech-debt Issues related to adjusting underlying implementation details without affecting the end product
Projects
None yet
Development

No branches or pull requests

2 participants