Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottleneck in Message Buffers #470

Open
walmat opened this issue Oct 18, 2019 · 0 comments
Open

Bottleneck in Message Buffers #470

walmat opened this issue Oct 18, 2019 · 0 comments
Assignees
Labels
area:frontend Related to Nebula's Frontend Electron app focus:electron things involving electron specific code priority:urgent Issues that need to be solved right away type:enhancement New feature or request
Milestone

Comments

@walmat
Copy link
Owner

walmat commented Oct 18, 2019

Describe the bug
One trace I've found when looking for bottlenecks was that the message buffer from the task manager is constantly looking for updates and overflows the event handler because of this.

To Reproduce
Steps to reproduce the behavior:

  1. Throw a console.error('transferring messages!') statement here
  2. Launch development mode: yarn dev-server && yarn dev
  3. Run 1 task
  4. View how many times the log prints out (will be inside of the launcher.html console)
  5. Repeat 1-5 with 50 tasks

Expected behavior
This bottleneck area should not cause any performance issues 😄

Screenshots
N/A - Can't be captured in a sreenshot

Desktop (please complete the following information):

  • OS: All
  • Service: Frontend + Task Runner
  • Version: 1.2.38+

Additional context
This is just one problem area that I've traced, it probably extends further back to the event emission done by the task manager itself even..

@walmat walmat added type:enhancement New feature or request area:frontend Related to Nebula's Frontend Electron app priority:urgent Issues that need to be solved right away focus:electron things involving electron specific code labels Oct 18, 2019
@walmat walmat added this to the 1.3.0 milestone Oct 18, 2019
@walmat walmat self-assigned this Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend Related to Nebula's Frontend Electron app focus:electron things involving electron specific code priority:urgent Issues that need to be solved right away type:enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant