Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Missing Profiles testing back #343

Closed
walmat opened this issue Feb 18, 2019 · 1 comment
Closed

Add Missing Profiles testing back #343

walmat opened this issue Feb 18, 2019 · 1 comment
Assignees
@walmat
Labels
area:frontend Related to Nebula's Frontend Electron app focus:layout things involving UI layout changes (for frontend) priority:low Issues that are low priority don't need to be solved right away type:tech-debt Issues related to adjusting underlying implementation details without affecting the end product
Milestone
Beta 7 Release

Comments

@walmat
Copy link
Owner

walmat commented Feb 18, 2019

Is your feature request related to a problem? Please describe.
The SASS rewrite, specifically the profiles rewrite caused a refactor to happen a little bit that mesed with testing.

Describe the solution you'd like
https://github.com/walmat/nebula/pull/335#discussion_r257486697
https://github.com/walmat/nebula/pull/335#discussion_r257486954

Describe alternatives you've considered
N/A

Additional context
Original issue: https://github.com/walmat/nebula/issues/325
@walmat walmat added area:frontend Related to Nebula's Frontend Electron app type:tech-debt Issues related to adjusting underlying implementation details without affecting the end product focus:layout things involving UI layout changes (for frontend) priority:low Issues that are low priority don't need to be solved right away labels Feb 18, 2019
@walmat walmat added this to the Beta 7 Release milestone Feb 18, 2019
@walmat walmat self-assigned this Feb 18, 2019
@walmat walmat mentioned this issue Feb 18, 2019
Merged
4 tasks
@walmat walmat mentioned this issue Mar 29, 2019
Merged
32 tasks
@pr1sm
Copy link
Collaborator

pr1sm commented Mar 30, 2019

fixed in #385, released in #402

@pr1sm pr1sm closed this as completed Mar 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@walmat walmat

Labels
area:frontend Related to Nebula's Frontend Electron app focus:layout things involving UI layout changes (for frontend) priority:low Issues that are low priority don't need to be solved right away type:tech-debt Issues related to adjusting underlying implementation details without affecting the end product
Projects
None yet
Milestone
Beta 7 Release
Development

No branches or pull requests
2 participants
@pr1sm @walmat