Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DSML hash property parsing #314

Closed
walmat opened this issue Feb 8, 2019 · 2 comments
Closed

DSML hash property parsing #314

walmat opened this issue Feb 8, 2019 · 2 comments
Assignees
@pr1sm
Labels
focus:monitor things involving site monitoring focus:parsing things involving site parsing (for task runner) priority:urgent Issues that need to be solved right away tag:drop-recap Issues that come from drop recaps type:bug Something isn't working
Milestone
Beta 6 Release

Comments

@walmat
Copy link
Owner

walmat commented Feb 8, 2019 •
edited
Loading

Describe the bug
Seems like DSM (NY more than L I've noticed) changes the hash property from time to time, so we need a way to parse out this property when running a task to avoid ATC failures.

To Reproduce
Steps to reproduce the behavior:
N/A

Expected behavior
We need to split into two sub-modules of DSMParser for US/UK that finds the hash for each site appropriately.

Screenshots
screen shot 2019-02-07 at 8 37 38 pm

Desktop (please complete the following information):

  • OS: All
  • Service: Task Runner
  • Version: Beta 5.2

Additional context
@walmat walmat added type:bug Something isn't working tag:drop-recap Issues that come from drop recaps labels Feb 8, 2019
@walmat walmat added priority:urgent Issues that need to be solved right away focus:parsing things involving site parsing (for task runner) focus:monitor things involving site monitoring labels Feb 8, 2019
@pr1sm pr1sm added this to the Beta 6 Release milestone Feb 8, 2019
@pr1sm pr1sm self-assigned this Feb 9, 2019
@pr1sm pr1sm mentioned this issue Feb 9, 2019
Merged
4 tasks
@walmat
Copy link
Owner Author

walmat commented Feb 10, 2019

Updating OP, DSML left to do

@walmat walmat changed the title DSML & DSM NY hash property parsing DSML hash property parsing Feb 10, 2019
@pr1sm pr1sm mentioned this issue Feb 11, 2019
Merged
6 tasks
@walmat
Copy link
Owner Author

walmat commented Feb 12, 2019

Oops. Fixed in #334. Closing

@walmat walmat closed this as completed Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pr1sm pr1sm

Labels
focus:monitor things involving site monitoring focus:parsing things involving site parsing (for task runner) priority:urgent Issues that need to be solved right away tag:drop-recap Issues that come from drop recaps type:bug Something isn't working
Projects
None yet
Milestone
Beta 6 Release
Development

No branches or pull requests
2 participants
@pr1sm @walmat