Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings Validation Middleware #295

Closed
walmat opened this issue Feb 1, 2019 · 1 comment
Closed

Settings Validation Middleware #295

walmat opened this issue Feb 1, 2019 · 1 comment
Labels
area:frontend Related to Nebula's Frontend Electron app priority:low Issues that are low priority don't need to be solved right away type:tech-debt Issues related to adjusting underlying implementation details without affecting the end product
Milestone
Beta 7 Release

Comments

@walmat
Copy link
Owner

walmat commented Feb 1, 2019

Is your feature request related to a problem? Please describe.
We currently have minimal validation middleware setup on the settings page. Currently only for proxies.

Describe the solution you'd like
All forms/inputs should have a validator tied to them.

Describe alternatives you've considered
N/A

Additional context
https://github.com/walmat/nebula/pull/292#discussion_r253227572
@walmat walmat added area:frontend Related to Nebula's Frontend Electron app type:tech-debt Issues related to adjusting underlying implementation details without affecting the end product labels Feb 1, 2019
@pr1sm pr1sm added the priority:low Issues that are low priority don't need to be solved right away label Feb 11, 2019
@walmat walmat mentioned this issue Mar 16, 2019
Merged
32 tasks
@pr1sm
Copy link
Collaborator

pr1sm commented Mar 30, 2019

fixed in #385, released in #402

@pr1sm pr1sm closed this as completed Mar 30, 2019
@pr1sm pr1sm added this to the Beta 7 Release milestone Mar 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:frontend Related to Nebula's Frontend Electron app priority:low Issues that are low priority don't need to be solved right away type:tech-debt Issues related to adjusting underlying implementation details without affecting the end product
Projects
None yet
Milestone
Beta 7 Release
Development

No branches or pull requests
2 participants
@pr1sm @walmat