Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor End-State messages for TaskRunner #193

Open
pr1sm opened this issue Dec 20, 2018 · 1 comment
Open

Refactor End-State messages for TaskRunner #193

pr1sm opened this issue Dec 20, 2018 · 1 comment
Labels
area:task-runner Related to Nebula's Task Runner package priority:low Issues that are low priority don't need to be solved right away type:tech-debt Issues related to adjusting underlying implementation details without affecting the end product

Comments

@pr1sm
Copy link
Collaborator

pr1sm commented Dec 20, 2018

Describe the bug
Currently the task runner doesn't have a good way to tell if a task has been stopped. This causes the frontend to fall out of sync in its redux store.

To Reproduce
Steps to reproduce the behavior:

  1. Create and run a task that errors out
  2. Verify that the end status message is posted (Task has error out or something similar)
  3. Check the redux state of that task in the frontend and it is probably still running

Expected behavior
When the task ends, the frontend should update its redux state accordingly so the state is kept in sync.

Desktop (please complete the following information):

  • OS: MWL
  • Service: task-runner
  • Version: alpha

Additional context
We can test the incoming message part of the status update to determine if a task has finished, but that's not a stable way to check.

@pr1sm pr1sm added type:tech-debt Issues related to adjusting underlying implementation details without affecting the end product area:task-runner Related to Nebula's Task Runner package labels Dec 20, 2018
@pr1sm
Copy link
Collaborator Author

pr1sm commented Dec 20, 2018

This issue can be solved relatively easy by sending a status key along with the message. This will allow the frontend to be notified of a change in state from the TaskRunner and enable it to update its state accordingly.

Specifically, the message here can be updated to include a status key. this would be a short, one-word status update such as errored, finished, or aborted.
https://github.com/walmat/nebula/blob/bfff2b05394d36324ed1cdfdec240a990ba245d8/packages/task-runner/src/shopify/taskRunner.js#L311)

@pr1sm pr1sm added the priority:low Issues that are low priority don't need to be solved right away label Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:task-runner Related to Nebula's Task Runner package priority:low Issues that are low priority don't need to be solved right away type:tech-debt Issues related to adjusting underlying implementation details without affecting the end product
Projects
None yet
Development

No branches or pull requests

1 participant