Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamically listen for harvest events #111

Closed
pr1sm opened this issue Nov 12, 2018 · 1 comment
Closed

Dynamically listen for harvest events #111

pr1sm opened this issue Nov 12, 2018 · 1 comment
Labels
area:frontend Related to Nebula's Frontend Electron app priority:low Issues that are low priority don't need to be solved right away status:invalid This doesn't seem right type:tech-debt Issues related to adjusting underlying implementation details without affecting the end product

Comments

@pr1sm
Copy link
Collaborator

pr1sm commented Nov 12, 2018

Is your feature request related to a problem? Please describe.
With #104 merging, we always listen when to start/stop harvesting captchas. This means that the listener gets attached event when the user never starts a task.

Describe the solution you'd like
Determine if there is a way to store when at least one task is running, then start/stop listening to the harvest events based on that instead of always listening.

Additional context
Relevant comment in source code
@pr1sm pr1sm added area:frontend Related to Nebula's Frontend Electron app type:tech-debt Issues related to adjusting underlying implementation details without affecting the end product labels Nov 12, 2018
@pr1sm pr1sm mentioned this issue Nov 12, 2018
Merged
7 tasks
@walmat walmat added this to the Beta 2 Release milestone Dec 29, 2018
@pr1sm pr1sm removed this from the Beta 3 Release milestone Jan 17, 2019
@walmat walmat added this to the Beta 5 Release milestone Feb 3, 2019
@pr1sm pr1sm removed this from the Beta 5 Release milestone Feb 8, 2019
@pr1sm pr1sm added the priority:low Issues that are low priority don't need to be solved right away label Feb 11, 2019
@pr1sm
Copy link
Collaborator Author

pr1sm commented Feb 22, 2019

Due to changes in #342, We do need this handler to always be active. closing this

@pr1sm pr1sm closed this as completed Feb 22, 2019
@pr1sm pr1sm added status:wontfix This will not be worked on status:invalid This doesn't seem right and removed status:wontfix This will not be worked on labels Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:frontend Related to Nebula's Frontend Electron app priority:low Issues that are low priority don't need to be solved right away status:invalid This doesn't seem right type:tech-debt Issues related to adjusting underlying implementation details without affecting the end product
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pr1sm @walmat