Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import read10xVisium function #3

Open
drighelli opened this issue Aug 28, 2023 · 1 comment
Open

import read10xVisium function #3

drighelli opened this issue Aug 28, 2023 · 1 comment
Assignees

Comments

@drighelli
Copy link

drighelli commented Aug 28, 2023

As already discussed multiple times with @LiNk-NY and in some other issues around, it would be nice to have all the import functions into a unique package. We think this would be a nice container for all of them.

So, Marcel asked me to import the read10xVisium function into this package to remove dependencies like dropletUtils from our SpatialExperiment class so I'm linking @lmweber and @HelenaLC to see if they agree with this process

@lmweber
Copy link

lmweber commented Aug 29, 2023

Yes, I think this makes sense to me, so there would be more of a separation between the core class (SpatialExperiment) and specific helper / loading functions that are only relevant for for certain platforms (read10xVisium()).

This would then also solve the DropletUtils dependencies issue in #139.

Is the plan also to import read10xCounts() from DropletUtils into the TENxIO package? Either way it would be good to have consistency between how read10xCounts() and read10xVisium() are handled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants