-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: removed incorrect go.mod instructions #3878
base: master
Are you sure you want to change the base?
chore: removed incorrect go.mod instructions #3878
Conversation
WalkthroughThe documentation for creating a project with Wails has been updated to enhance clarity and usability. Key changes include the introduction of a tabbed interface for selecting frameworks like Svelte, React, and Vue, along with specific commands for project generation in JavaScript and TypeScript. The project layout section has been refined to clearly describe the directory structure, while a previous note regarding the default module name in Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Nice find!🙏 Please could you add an entry to the changelog located at |
I must have responded to an older version of this page :-) |
Quality Gate passedIssues Measures |
Do I have to do anything else here @leaanthony or will it just get picked up when it gets picked up? I merged master back in so it didn't fall too far behind. |
Description
This change removes references of
The default module name in go.mod is "changeme". You should change this to something more appropriate.
which are no longer necessary as creating a new wails project uses the project name correctly.Fixes #3877
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration using
wails doctor
.I have checked both windows and linux as I am using WSL.
Test Configuration
Please paste the output of
wails doctor
. If you are unable to run this command, please describe your environment in as much detail as possible.Using WSL I built and served the documentation website and confirmed that the unnecessary message is no longer being displayed.
Checklist:
website/src/pages/changelog.mdx
with details of this PRSummary by CodeRabbit
New Features
wails init
command, supporting frameworks like Svelte, React, Vue, Preact, Lit, and Vanilla.Bug Fixes
go.mod
, simplifying instructions.Documentation