-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v3] Restore ToggleMaximise method in Window interface #3281
Conversation
Important Auto Review SkippedAuto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
f61f747
to
2e629c4
Compare
Amazing PR! Thank you 🙏 Nothing to add here really, only that I need to create that FSHandler that includes the compiled runtime instead of copying it everywhere 😅 |
Description
The ToggleMaximise method from wails v2 is useful for custom window controls but was initially omitted from the Window interface.
This patch reintroduces it (ensuring it works properly when called from JS code). No runtime update is required.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I tested the method on macOS 12 through the
window-api
example.Test Configuration
Checklist:
mkdocs-website/docs/en/changelog.md
with details of this PR