Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[windows] Improve fullscreen mode for frameless windows #2279

Merged
merged 3 commits into from
Jan 9, 2023
Merged

[windows] Improve fullscreen mode for frameless windows #2279

merged 3 commits into from
Jan 9, 2023

Conversation

stffabi
Copy link
Collaborator

@stffabi stffabi commented Jan 8, 2023 •
edited
Loading

  • In fullscreen the taskbar was not fully covered when previously maximized
  • Unfullscreen did not correctly relayout the content
  • Prevent Unmaximise/Unminimise when in fullscreen mode
  • Use POPUP style for fullscreen mode

Fixes #2285

@stffabi stffabi force-pushed the bugfix/windows-frameless-fullscreen branch 3 times, most recently from 77f4e8b to 564efb1 Compare January 9, 2023 08:46
@stffabi stffabi changed the title [windows] Fix fullscreen mode for frameless windows and set window background colour [windows] Improve fullscreen mode for frameless windows Jan 9, 2023
@stffabi stffabi force-pushed the bugfix/windows-frameless-fullscreen branch from ecc4519 to a00490f Compare January 9, 2023 10:38
@stffabi stffabi marked this pull request as ready for review January 9, 2023 10:38
@stffabi
[windows] Improve fullscreen mode for frameless windows
1f30810 
- In fullscreen the taskbar was not fully covered when previously maximized
- Unfullscreen did not correctly relayout the content
- Prevent Unmaximise/Unminimise when in fullscreen mode
- Use POPUP style for fullscreen mode
@stffabi
[windows] Set Window background color in addition to WebView2 backgro…
ad5c6f2 
…und color
@stffabi
[docs] Add changelog
b246f40
@stffabi stffabi force-pushed the bugfix/windows-frameless-fullscreen branch from a00490f to b246f40 Compare January 9, 2023 10:50
leaanthony
leaanthony approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@leaanthony leaanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stffabi stffabi merged commit 8e4606d into wailsapp:master Jan 9, 2023
@stffabi stffabi deleted the bugfix/windows-frameless-fullscreen branch January 9, 2023 11:15
@stffabi
Copy link
Collaborator Author

stffabi commented Jan 9, 2023

Thanks for approving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leaanthony leaanthony leaanthony approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Frameless window Fullscreen mode issue in windows 10
2 participants
@stffabi @leaanthony