Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to specify path to WebView2 #1446

Closed
NanoNik opened this issue Jun 11, 2022 · 1 comment · Fixed by #1448
Closed

Ability to specify path to WebView2 #1446

NanoNik opened this issue Jun 11, 2022 · 1 comment · Fixed by #1448
Labels
Enhancement New feature or request
Milestone

Comments

@NanoNik
Copy link
Contributor

NanoNik commented Jun 11, 2022

Is your feature request related to a problem? Please describe.

I'm building an application using wails v2, what I want to do is to download webview2 in a separate bootstrapper that will download all dependencies of the application (including webview2, if not installed), and then use downloaded (not installed in the system) version.

I think it's not very good for user experience to pop up messages and force them to download a webview or silently download it without any visual feedback.

Also, this could be helpful when debugging issues with a specific version of webview2.

Describe the solution you'd like

Basically just add a new field in struct windows.Options and pass it to createCoreWebView2EnvironmentWithOptions

options := &windows.Options {
    WebviewBrowserPath: "webview_downloaded/",
}

Describe alternatives you've considered

No response

Additional context

No response

@NanoNik NanoNik added the Enhancement New feature or request label Jun 11, 2022
@leaanthony leaanthony added this to the v2.1.0 milestone Jun 11, 2022
@leaanthony
Copy link
Member

I see a benefit in this and am happy to accept a PR for it. It sounds like you already know what needs doing 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants