Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposals #1

Open
CVarisco opened this issue Jul 23, 2017 · 2 comments
Open

proposals #1

CVarisco opened this issue Jul 23, 2017 · 2 comments

Comments

@CVarisco
Copy link
Contributor

Hi @wagenaartje !

I like your idea 🙂 , and I started a little refactoring on my fork with your code style.
But I propose a contribution guide to help other people to contribute.
And it would be great if everything is written in ES6.

What do you think about it ?
Have a nice day 🌮

@wagenaartje
Copy link
Owner

Love the improvement you made. It makes requests more generic, leaving some room open for future functions that will also make requests. I'll see the PR appear whenever 😄

Great idea. I'll create a CONTRIBUTING.md soon that contains goals for the future as well as a simple guide on how to get started with contributing.

As for the style guide, i'd like to stick to Semi-StandardJS. I have never actually read through the ES6 coding style specifically, but i'll do that soon (and i'll include it in the contributing file).

Have a nice day too 🍕

@ghost
Copy link

ghost commented Jan 10, 2018

Is there any plan to add functionality for getting digital currency quotes, as alpha advantage offers this through their api?

I created a digitalCurrency method locally that takes an options object like all the other methods, but the problem comes with the _convertData function. It seems to not find the correct keys, and returns some funky data.

Is anything digital currency related something that might be in the future of stocks.js since crypto currency is related to investing like stocks on the NYSE?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants