Skip to content

Commit 98657b0

Browse files
committed
Rename filter to InvalidXmlCharacterFilter
1 parent 3205a0c commit 98657b0

File tree

3 files changed

+28
-12
lines changed

3 files changed

+28
-12
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
* that any characters not allowed in XML 1.0 are filtered out before parsing.
1212
* </p>
1313
*/
14-
public class RemoveInvalidCharacterFeedFilter implements FeedFilter {
14+
public class InvalidXmlCharacterFilter implements FeedFilter {
1515

1616
/**
1717
* Filters the provided XML feed stream by removing invalid XML characters.
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
package com.apptasticsoftware.integrationtest;
2+
3+
import com.apptasticsoftware.rssreader.RssReader;
4+
import com.apptasticsoftware.rssreader.filter.InvalidXmlCharacterFilter;
5+
import org.junit.jupiter.api.Test;
6+
7+
import java.io.InputStream;
8+
import java.util.stream.Collectors;
9+
10+
import static org.junit.jupiter.api.Assertions.assertEquals;
11+
12+
public class FeedFilterTest {
13+
14+
@Test
15+
void testInvalidXmlCharacter0x6() {
16+
var fileInputSteam = fromFile("rss-invalid-xml-character-0x6.xml");
17+
var list = new RssReader()
18+
.addFeedFilter(new InvalidXmlCharacterFilter())
19+
.read(fileInputSteam)
20+
.collect(Collectors.toList());
21+
assertEquals(25, list.size());
22+
}
23+
24+
private InputStream fromFile(String fileName) {
25+
return getClass().getClassLoader().getResourceAsStream(fileName);
26+
}
27+
}

src/test/java/com/apptasticsoftware/integrationtest/RssReaderIntegrationTest.java

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package com.apptasticsoftware.integrationtest;
22

33
import com.apptasticsoftware.rssreader.*;
4-
import com.apptasticsoftware.rssreader.filter.RemoveInvalidCharacterFeedFilter;
54
import org.junit.jupiter.api.Disabled;
65
import org.junit.jupiter.api.Test;
76

@@ -600,16 +599,6 @@ void testUserAgent() throws IOException {
600599
assertTrue(list.size() > 10);
601600
}
602601

603-
@Test
604-
void testBadXmlCharacter0x6() {
605-
var fileInputSteam = fromFile("rss-invalid-xml-character-0x6.xml");
606-
var list = new RssReader()
607-
.addFeedFilter(new RemoveInvalidCharacterFeedFilter())
608-
.read(fileInputSteam)
609-
.collect(Collectors.toList());
610-
assertEquals(25, list.size());
611-
}
612-
613602
@Test
614603
void testHttpHeader() throws IOException {
615604
List<Item> items = new RssReader().addHeader("If-None-Match", "response_version1")

0 commit comments

Comments
 (0)