Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update verifying Relayer Proofs which check the XcmpChannelRoots instead of just the MmrRoot hack #101

Closed
Tracked by #52
coax1d opened this issue Nov 20, 2023 · 1 comment
Closed
Tracked by #52

Update verifying Relayer Proofs which check the XcmpChannelRoots instead of just the MmrRoot hack #101

coax1d opened this issue Nov 20, 2023 · 1 comment

Comments

@coax1d
Copy link
Collaborator

coax1d commented Nov 20, 2023 •
edited
Loading

Currently in pallet-xcmp-message-stuffer the extrinsic submit_xcmp_proof verifies an mmr proof from the relayer via a manually updated root (Which is just for testing purposes and is in no way secure) called update_root().

Need to replace the current approach by checking the current XcmpChannelMmrRoot for the particular channel_id instead which is updated in a trustless manner.
@coax1d coax1d mentioned this issue Nov 20, 2023
Open
22 tasks
@coax1d coax1d changed the title Update submitting Relayer Proofs which check the XcmpChannelRoots instead of just the MmrRoot hack Update verifying Relayer Proofs which check the XcmpChannelRoots instead of just the MmrRoot hack Nov 20, 2023
@coax1d
Copy link
Collaborator Author

coax1d commented Nov 23, 2023

Closed in favor of #112

@coax1d coax1d closed this as completed Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@coax1d