Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definition 154 is mistaken #725

Open
josepot opened this issue Jun 22, 2024 · 0 comments
Open

Definition 154 is mistaken #725

josepot opened this issue Jun 22, 2024 · 0 comments
Assignees

Comments

@josepot
Copy link

josepot commented Jun 22, 2024

There are a few issues with definition 154:

  1. The link to the "external SS58 address format" is broken.
  2. The reference to SS58 address format is IMO completely unnecessary, as the SS58 format is just a possible representation of the bytes of the address. In other words, the SS58 format is just derived from the bytes of the address, the only thing that's relevant are the actual bytes.
  3. Since transaction version 2 the address is in fact a MultiAddress. Therefore, Ai is not a 32 bytes address but rather a multi-address variant which should be properly defined.
@bhargavbh bhargavbh self-assigned this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants