Skip to content

Conversation

@dastansam
Copy link
Contributor

Fiat on-off ramps amendment

Hey there!

We are submitting this amendment as per our discussion in the Element chat. Core part of the deliverable of this milestone is updated, since it would not make sense to add smart contract support for a simple demo app. Instead, we are currently making necessary changes on the protocol level (adding extrinsics, storage entries, etc.) so that there is no need for us to add smart contract support. This is mostly a huge refactoring work, which you can track here in this PR. It is almost complete and once we merge this PR, we will start working on the milestone 3 deliverable: a DApp connected to our chain.

Duration is increased to 1.5 months, due to the above details. So, we assume that the deliverable for this milestone will be ready in around 1 month, assuming that we are on the finish line with refactoring work.

@CLAassistant
Copy link

CLAassistant commented Jan 9, 2023

CLA assistant check
All committers have signed the CLA.

@dastansam dastansam mentioned this pull request Jan 9, 2023
6 tasks
@dastansam
Copy link
Contributor Author

@keeganquigley tagging for visibility, thanks

@Noc2 Noc2 added ready for review The project is ready to be reviewed by the committee members. amendment This PR proposes changes to an existing application. and removed ready for review The project is ready to be reviewed by the committee members. labels Jan 10, 2023
@Noc2 Noc2 self-assigned this Jan 10, 2023
Copy link
Contributor

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR and the update. Could @wstrametz and @wasabrot also confirm that they are happy with the changes since they created the original application? Also, could everyone who contributed to the PR still sign our latest terms and conditions?

@Noc2 Noc2 added the changes requested The team needs to clarify a few things first. label Jan 10, 2023
@wasabrot
Copy link
Contributor

Thanks a lot for the PR and the update. Could @wstrametz and @wasabrot also confirm that they are happy with the changes since they created the original application? Also, could everyone who contributed to the PR still sign our latest terms and conditions?

Yes - confirm that, we worked on that together last couple of days

@wstrametz
Copy link
Contributor

Thanks a lot for the PR and the update. Could @wstrametz and @wasabrot also confirm that they are happy with the changes since they created the original application? Also, could everyone who contributed to the PR still sign our latest terms and conditions?

Yes - confirm that, we worked on that together last couple of days

Affirmative - also confirm that.

Copy link
Contributor

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick reply here. I'm happy to go ahead with it and share it with the rest of the team.

@Noc2 Noc2 added ready for review The project is ready to be reviewed by the committee members. and removed changes requested The team needs to clarify a few things first. labels Jan 10, 2023
Copy link
Contributor

@randombishop randombishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

amendment This PR proposes changes to an existing application. ready for review The project is ready to be reviewed by the committee members.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants