Skip to content

Commit 1fc04e2

Browse files
author
epriestley
committed
Fix repository URI generation for SVN commit identifiers represented with integer types
Summary: Ref T13588. See PHI2198. Some pathways represent SVN commit identifiers (which are numeric) with integers; these raise an exception in `phutil_nonempty_string()`, which is strict. (Ideally, commit identifiers wouldn't have mixed types, but that's a dramatically less practical change.) Test Plan: Will deploy. Maniphest Tasks: T13588 Differential Revision: https://secure.phabricator.com/D21852
1 parent 944b257 commit 1fc04e2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/applications/repository/storage/PhabricatorRepository.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -752,7 +752,7 @@ public function generateURI(array $params) {
752752
}
753753

754754
$raw_commit = $commit;
755-
if (phutil_nonempty_string($commit)) {
755+
if (phutil_nonempty_scalar($commit)) {
756756
$commit = str_replace('$', '$$', $commit);
757757
$commit = ';'.phutil_escape_uri($commit);
758758
}

0 commit comments

Comments
 (0)