Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should tm:required have a default value? #1581

Open
egekorkan opened this issue Jul 13, 2022 · 5 comments
Open

Should tm:required have a default value? #1581

egekorkan opened this issue Jul 13, 2022 · 5 comments
Labels
Defer to TD 2.0 Propose closing Problem will be closed shortly if there is no veto. Thing Model Topic related to Thing Models

Comments

@egekorkan
Copy link
Contributor

Coming from #1400, it might be a good idea to specify a default value for tm:required in order to say that all affordances are required unless otherwise specified. We can collect opinions here

@github-actions github-actions bot added the needs-triage Automatically added to new issues. TF should triage them with proper labels label Jul 13, 2022
@egekorkan egekorkan added Thing Model Topic related to Thing Models and removed needs-triage Automatically added to new issues. TF should triage them with proper labels labels Jul 14, 2022
@egekorkan
Copy link
Contributor Author

Given that this would imply changes implementations, probably for 2.0. Some other directions might be having another value type for it with values like "all", "properties/*" to have some shortcuts.

@sebastiankb
Copy link
Contributor

I think, we can also express in the spec that the following convention such as:

    "tm:required": [
        "/properties",
        "/actions/fadeIn"
    ]

have to interpret, that all properties are required and all other affordances such as actions, except fadeIn, and events are optional.

@sebastiankb
Copy link
Contributor

from today's TD call:

  • it seems to be there is no perfect solution since there can be different use cases with different requirements (e.g., there are 100 properties, however, two of them are optional)
  • we should be more clear, that required is optional. We need to update the assertion.
  • at the end it is also a question of the used tooling that generates TD instances out of TMs and what are there default assumptions (e.g., in case of optional affordances)
  • the group discussed 4 options:
  1. no default
  2. default is "all required" --> would break JSON Schema paradigm
  3. default is "none required" --> as is
  4. we will define "required" mandatory
  • please provide your opinions on these options

@egekorkan
Copy link
Contributor Author

not relevant anymore, closing

@JKRhb JKRhb added the Propose closing Problem will be closed shortly if there is no veto. label Aug 19, 2024
@JKRhb
Copy link
Member

JKRhb commented Aug 19, 2024

not relevant anymore, closing

Hmm, has this issue been kept open intentionally, or could it actually be closed then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defer to TD 2.0 Propose closing Problem will be closed shortly if there is no veto. Thing Model Topic related to Thing Models
Projects
None yet
Development

No branches or pull requests

4 participants