Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Property forms in Example 23 missing SSE subprotocol #398

Closed
benfrancis opened this issue Nov 2, 2023 · 2 comments
Closed

Property forms in Example 23 missing SSE subprotocol #398

benfrancis opened this issue Nov 2, 2023 · 2 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists Profile-1.0

Comments

@benfrancis
Copy link
Member

I've noticed that the Forms in Example 23 are missing a subprotocol member to denote that the endpoints supports SSE.

There should probably be two forms for each of the property affordances, both with the same value for href but one with op set to ["readproperty", "writeproperty"] and the other with op set to ["observeproperty", "unobserveproperty"] and subprotocol set to sse.
@benfrancis benfrancis added the bug Something isn't working label Nov 2, 2023
@benfrancis benfrancis mentioned this issue Feb 1, 2024
Open
@benfrancis
Copy link
Member Author

I think this is actually a duplicate of #370 🤦

@mlagally
Copy link
Contributor

@benfrancis Can we close this issue and continue in #370?

@mlagally mlagally added the duplicate This issue or pull request already exists label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists Profile-1.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benfrancis @mlagally