Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codec input to setParameters shouldn't be validated by preferred receive codecs #2989

Closed
jan-ivar opened this issue Aug 28, 2024 · 3 comments · May be fixed by #2991
Closed

codec input to setParameters shouldn't be validated by preferred receive codecs #2989

jan-ivar opened this issue Aug 28, 2024 · 3 comments · May be fixed by #2991

Comments

@jan-ivar
Copy link
Member

Step 4 of the setParameters validation steps says: "If choosableCodecs is an empty list, set choosableCodecs to transceiver.[[PreferredCodecs]].".

transceiver.[[PreferredCodecs]] are receive codecs set through setCodecPreferences and shouldn't be used to validate send codec.

@jan-ivar jan-ivar changed the title codec input to setParameters shouldn't be validated by receive preferred codecs codec input to setParameters shouldn't be validated by preferred receive codecs Aug 28, 2024
@alvestrand
Copy link
Contributor

Actually [[PreferredCodecs]] includes send codecs if set by this section:

Agree that this is unclear. Ideally, we should validate it over the set of codecs in the remote description, if set; if remote description is not set, it seems to me that it can only be validated over the set of implemented send codecs. (And we may want to include language saying that we enable any implemented send codec that is selected by setParameters).

@docfaraday
Copy link
Contributor

Actually [[PreferredCodecs]] includes send codecs if set by this section:

Agree that this is unclear. Ideally, we should validate it over the set of codecs in the remote description, if set; if remote description is not set, it seems to me that it can only be validated over the set of implemented send codecs. (And we may want to include language saying that we enable any implemented send codec that is selected by setParameters).

I don't see that section setting [[PreferredCodecs]]. It does seem to assume that [[PreferredCodecs]] might contain send codecs, but I do not see anywhere that will put send codecs in there. The language probably needs to be updated to reflect that this will only contain recv codecs.

@henbos
Copy link
Contributor

henbos commented Oct 2, 2024

Regarding whether preferences are send, receive or both, this was discussed at TPAC. We need to go through the spec and make sure everything is consistent with this decision, but I filed #3006 for this work in order to close all the overlapping codec issues such as this one

@henbos henbos closed this as completed Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants