Use [=AbortSignal/abort reason=]
#86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saschanaz
commented
Nov 10, 2021
inexorabletash
approved these changes
Nov 10, 2021
annevk
reviewed
Nov 10, 2021
13 tasks
|
I think we can merge once WPTs are ready... and how are implementations going? |
saschanaz
force-pushed
the
abort-reason
branch
from
5cb2d99
to
4933b62
Compare
|
Will take a look at Gecko implementation soon-ish. |
inexorabletash
added a commit
that referenced
this pull request
Nov 12, 2021
saschanaz
added a commit
to saschanaz/web-locks
that referenced
this pull request
Nov 12, 2021
Split from w3c#86 as it's not directly related to abort reasons.
inexorabletash
pushed a commit
that referenced
this pull request
Nov 12, 2021
|
The patch has landed to Gecko and WPT changes are here: web-platform-tests/wpt#32055 |
|
Nice! I suppose we need a tracking bug in Blink... |
|
Could you open one or should I? |
github-actions bot
added a commit
that referenced
this pull request
Dec 14, 2021
SHA: 526a0fe Reason: push, by @inexorabletash Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
crbug.com/1279877 |
Closed
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 15, 2022
Updated in the spec a year ago[1], if the AbortSignal has a reason, use that as the rejection, rather than a stock AbortError w/ hardcoded message. The WPTs didn't cover verifying the reason for an already-aborted signal, so add coverage for those cases too. [1] w3c/web-locks#86 Bug: 1279877 Change-Id: I9838805b10dbb3dae0371abe41faf922344a43f3
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 16, 2022
Updated in the spec a year ago[1], if the AbortSignal has a reason, use that as the rejection, rather than a stock AbortError w/ hardcoded message. The WPTs didn't cover verifying the reason for an already-aborted signal, so add coverage for those cases too. [1] w3c/web-locks#86 Bug: 1279877 Change-Id: I9838805b10dbb3dae0371abe41faf922344a43f3
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 16, 2022
Updated in the spec a year ago[1], if the AbortSignal has a reason, use that as the rejection, rather than a stock AbortError w/ hardcoded message. The WPTs didn't cover verifying the reason for an already-aborted signal, so add coverage for those cases too. [1] w3c/web-locks#86 Bug: 1279877 Change-Id: I9838805b10dbb3dae0371abe41faf922344a43f3
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Dec 16, 2022
Updated in the spec a year ago[1], if the AbortSignal has a reason, use that as the rejection, rather than a stock AbortError w/ hardcoded message. The WPTs didn't cover verifying the reason for an already-aborted signal, so add coverage for those cases too. [1] w3c/web-locks#86 Bug: 1279877 Change-Id: I9838805b10dbb3dae0371abe41faf922344a43f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4112925 Reviewed-by: Ayu Ishii <ayui@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/main@{#1084556}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 16, 2022
Updated in the spec a year ago[1], if the AbortSignal has a reason, use that as the rejection, rather than a stock AbortError w/ hardcoded message. The WPTs didn't cover verifying the reason for an already-aborted signal, so add coverage for those cases too. [1] w3c/web-locks#86 Bug: 1279877 Change-Id: I9838805b10dbb3dae0371abe41faf922344a43f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4112925 Reviewed-by: Ayu Ishii <ayui@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/main@{#1084556}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 16, 2022
Updated in the spec a year ago[1], if the AbortSignal has a reason, use that as the rejection, rather than a stock AbortError w/ hardcoded message. The WPTs didn't cover verifying the reason for an already-aborted signal, so add coverage for those cases too. [1] w3c/web-locks#86 Bug: 1279877 Change-Id: I9838805b10dbb3dae0371abe41faf922344a43f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4112925 Reviewed-by: Ayu Ishii <ayui@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/main@{#1084556}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 22, 2022
…nal, use signal's reason, a=testonly Automatic update from web-platform-tests Web Locks: If aborted due to an AbortSignal, use signal's reason Updated in the spec a year ago[1], if the AbortSignal has a reason, use that as the rejection, rather than a stock AbortError w/ hardcoded message. The WPTs didn't cover verifying the reason for an already-aborted signal, so add coverage for those cases too. [1] w3c/web-locks#86 Bug: 1279877 Change-Id: I9838805b10dbb3dae0371abe41faf922344a43f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4112925 Reviewed-by: Ayu Ishii <ayui@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/main@{#1084556} -- wpt-commits: 9ce4a6482a088da3d74f895d8ad15c5ce0c25d28 wpt-pr: 37535
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Jan 3, 2023
…nal, use signal's reason, a=testonly Automatic update from web-platform-tests Web Locks: If aborted due to an AbortSignal, use signal's reason Updated in the spec a year ago[1], if the AbortSignal has a reason, use that as the rejection, rather than a stock AbortError w/ hardcoded message. The WPTs didn't cover verifying the reason for an already-aborted signal, so add coverage for those cases too. [1] w3c/web-locks#86 Bug: 1279877 Change-Id: I9838805b10dbb3dae0371abe41faf922344a43f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4112925 Reviewed-by: Ayu Ishii <ayui@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/main@{#1084556} -- wpt-commits: 9ce4a6482a088da3d74f895d8ad15c5ce0c25d28 wpt-pr: 37535
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From whatwg/dom#1030
cc @annevk
Will also modify relevant WPT tests soon.
Preview | Diff