Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More narrative description/ background #59

Closed
samuelweiler opened this issue Jan 27, 2022 · 4 comments
Closed

More narrative description/ background #59

samuelweiler opened this issue Jan 27, 2022 · 4 comments
Labels
has-pr pending close security-needs-resolution Issue the security Group has raised and looks for a response on.

Comments

@samuelweiler
Copy link
Member

There are some words in the scope section, namely "presentations" and "proofs" that don't make much sense on their own, and there is not sufficient background text here to understand them. Perhaps adding a background section/discussion as an intro to the charter would help?

I'm marking this one -needs-resolution because it's about explaining the substance.

@brentzundel
Copy link
Member

my first inclination was to grab the text from the VC Data Model Introduction and paste it into the charter, but I worry that may be overkill. Would linking to that section from the charter be sufficient to address this issue @samuelweiler ?

@brentzundel
Copy link
Member

PR #75 has been raised to address this issue. @samuelweiler please let us know if this PR addresses this issue to your satisfaction.

@brentzundel
Copy link
Member

PR #75 has been merged. I am marking this issue as pending close as I believe it has been addressed.

It will be closed in 7 days if there are no objections.

@brentzundel
Copy link
Member

no comments since marked pending closed, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-pr pending close security-needs-resolution Issue the security Group has raised and looks for a response on.
Projects
None yet
Development

No branches or pull requests

2 participants