Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial(ish): Incorrect method reference in algorithm for checkIntersection/checkEnclosure #558

Open
fsoder opened this issue Oct 18, 2018 · 2 comments

Comments

@fsoder
Copy link

fsoder commented Oct 18, 2018

In the algorithm for checkIntersection [1] (checkEnclosure analogously) it says:

...depending on what method we are in:

  • getIntersectionList ...

which ought to say checkIntersection.

[1] https://svgwg.org/svg2-draft/struct.html#__svg__SVGSVGElement__checkIntersection (this was the "closest" reference I could find - wishful thinking would have it actually reference the algorithm for said method) - search for "When checkIntersection".

@dirkschulze
Copy link
Contributor

@fsoder That method would call itself then. The idea is to get the list of descendants first and perform the actual task in step 2-5.

@fsoder
Copy link
Author

fsoder commented Oct 28, 2018

That method would call itself then.

No it wouldn't, see below. (And above...)

The idea is to get the list of descendants first and perform the actual task in step 2-5.

Yes, and to do that (invoke [1]), the algorithm dispatches using the method it is invoked from, which for checkIntersection() or checkEnclosure() would mean that - as written - the list of descendants would always be empty (because we're never invoking this algorithm from getIntersectionList() or getEnclosureList().)

[1] https://svgwg.org/svg2-draft/struct.html#TermFindIntersectingOrEnclosedDescendants

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants