From a0c9bdabb31f4175fcbf99267a0b306140f849a2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fran=C3=A7ois=20Daoust?= Date: Thu, 6 Jun 2024 22:17:56 +0200 Subject: [PATCH] Fix Puppeteer instance teardown (#1586) The code was not waiting for the browser instance to get properly closed. That did not affect the result of the crawl, but the OS could report an error message such as "A child process was not properly killed" when the crawl command exited. --- src/lib/specs-crawler.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/specs-crawler.js b/src/lib/specs-crawler.js index 33a95c1e..dc7e6780 100644 --- a/src/lib/specs-crawler.js +++ b/src/lib/specs-crawler.js @@ -504,7 +504,7 @@ async function crawlList(speclist, crawlOptions) { // Close Puppeteer instance if (!crawlOptions.useCrawl) { - teardownBrowser(); + await teardownBrowser(); } return results;