Skip to content
This repository has been archived by the owner on Jul 30, 2019. It is now read-only.

Unescape HTML - as per style guide #1280

Merged
merged 3 commits into from
Mar 9, 2018
Merged

Unescape HTML - as per style guide #1280

merged 3 commits into from
Mar 9, 2018

Conversation

edent
Copy link
Member

@edent edent commented Mar 4, 2018

This patch turns " into " and † into etc.

Makes the source easier to read and search. Complies with #1193

* Unicode is cool!
* We have to leave the GRAVE alone otherwise markdown gets confused
* Also `<` and `>` to stop accidental HTMLification
* As per #1193
@edent edent requested a review from agcolom March 4, 2018 11:15
@edent
Copy link
Member Author

edent commented Mar 6, 2018

This has passed CI - I don't know why it is saying it hasn't https://travis-ci.org/w3c/html/builds/348892330?utm_source=github_status&utm_medium=notification

Copy link
Collaborator

@chaals chaals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we turn a list into a list? Other than that, LGTM - feel free to make the change or explain why not, then merge it yourself

@@ -324,8 +324,8 @@
<img src="images/focus-tree.png" alt="" width="800" height="450" />

If the widget with <a>focus</a> in this example was the text field in the dialog box, then key
input would be channeled from the graphical system to &#x2460; the Web browser, then to &#x2461;
the tab, then to &#x2462; the dialog, and finally to &#x2463; the text field.
input would be channeled from the graphical system to ① the Web browser, then to ②
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not make these a normal ordered list?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because in translation, I assume the ol-li could become 一,二,三,四. Whereas the image has circled numbers on it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, thanks.

@edent edent merged commit bb392bc into master Mar 9, 2018
@edent edent deleted the 1193-unescape-edent branch March 9, 2018 10:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants