Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scroll-animations-1] should ViewTimelineOptions.subject be required? #9584

Open
graouts opened this issue Nov 9, 2023 · 1 comment
Open
Assignees
Labels

Comments

@graouts
Copy link
Contributor

graouts commented Nov 9, 2023

While reviewing an early patch for ViewTimeline and ViewTimelineOptions in WebKit, a question about the spec came up:

I suspect the spec intended this dictionary member to be marked as required since it is not nullable and the corresponding attribute on the interface is not nullable either. May be worth filing an issue against the spec.

Should the ViewTimelineOptions be specified as follows?

dictionary ViewTimelineOptions {
  required Element subject;
  ScrollAxis axis = "block";
  (DOMString or sequence<(CSSNumericValue or CSSKeywordValue)>) inset = "auto";
};
@birtles
Copy link
Contributor

birtles commented Nov 10, 2023

I'm not familiar with ViewTimeline I'm afraid. Removing myself as reviewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants