-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[web-animations-1] Does an animation have pending events? #8004
Comments
Hi @jakearchibald, what's missing in the definition of the queue? |
IMO: It shouldn't be called a queue unless the items are in the right order. So, either call it "pending animation events", make it a list, and note that it's out of order, or call it "pending animation events queue", a queue, and insert items in the correct order. The items should be a defined struct, so the event object and target of a pending animation event can be referenced. Happy to make a PR. |
Because the events get sorted again before being dispatched? So it's more like a pending events bucket? That's a fair point. I'll try to have a proper look tomorrow. |
I'm being pretty nitpicky I think, so I don't think this is high priority. |
So my understanding of what is required here:
(Note that animation playback events target |
In the view transitions spec we want to know when all animations targeting particular elements are finished/idle. However, we want to wait long enough so an additional animation can be changed in the "finish" event or
.finished
promise reaction callback.We currently have prose like:
But that seems a bit hand-wavy, since the queue isn't really defined. It stores event objects, but also kinda animations too?
I'm not sure what the right way forward here is. Maybe the animation spec could include a "has pending events" definition and export that?
The text was updated successfully, but these errors were encountered: