Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider reverting “allow child-index pseudos to select unparented elements” change #695

Closed
sideshowbarker opened this issue Nov 9, 2016 · 4 comments
Labels
selectors-4 Current Work

Comments

@sideshowbarker
Copy link
Contributor

sideshowbarker commented Nov 9, 2016

Spec section: https://drafts.csswg.org/selectors-4/#child-index

Original CSS WG issue: https://www.w3.org/Style/CSS/Tracker/issues/317
Discussion: https://lists.w3.org/Archives/Public/www-style/2013Mar/thread.html#msg290

But see also https://lists.w3.org/Archives/Public/www-archive/2016Oct/0009.html

At the time when this spec change was made more than 3 years ago at a time, we had interoperability among all UAs on this: They all implemented the original spec requirements. And in the 3 years since, Gecko is the only engine that has changed to match the spec change. So interop on this has now regressed, and it’s not clear if there are even any Blink/WebKit/Edge browser bugs open to request those other browsers implement this change.

So it seems like consideration should be made about either reverting the change or else getting some browser bugs raised and making an effort to get back to interoperability on this.

@sideshowbarker sideshowbarker added the selectors-4 Current Work label Nov 9, 2016
@tabatkins
Copy link
Member

Browser bugs are the right way to do this. Something like this change is necessary to make the child pseudos work in the expected way on shadow trees (otherwise, all the top-level elements don't match, because they don't have a parent), and it's dumb to carve out a special exception for shadow trees while still making <html> not match. I'll file a Chrome bug, at least.

@Ms2ger
Copy link

Ms2ger commented Dec 19, 2016

https://bugs.chromium.org/p/chromium/issues/detail?id=675670

@yisibl
Copy link
Contributor

yisibl commented Jun 20, 2017

@tabatkins
Copy link
Member

Since we have two implementations, I'm gonna go ahead and close this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
selectors-4 Current Work
Projects
None yet
Development

No branches or pull requests

4 participants