Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-shadow-parts][css-view-transitions] Are view transition pseudo-elements allowed after ::part()? #10806

Closed
dbaron opened this issue Aug 30, 2024 · 3 comments
Closed

[css-shadow-parts][css-view-transitions] Are view transition pseudo-elements allowed after ::part()? #10806

dbaron opened this issue Aug 30, 2024 · 3 comments
Labels
css-shadow-parts-1 css-view-transitions-1 View Transitions; Bugs only

Comments

@dbaron
Copy link
Member

dbaron commented Aug 30, 2024

My understanding of the view transition pseudo-elements is that they are all pseudo-elements on the root element. This means they don't really make sense to be allowed after ::part(), despite that the ::part spec says that all pseudo-elements are allowed after ::part().

If we agree in #10786 that the rules on what is allowed after ::part() are a parse-time restriction, then we probably need to decide whether the view transition pseudo-elements should be allowed. My current inclination is that they probably shouldn't be since they could never match, but I don't have a strong opinion.
@dbaron dbaron added css-shadow-parts-1 css-view-transitions-1 View Transitions; Bugs only labels Aug 30, 2024
@nt1m
Copy link
Member

nt1m commented Aug 30, 2024

It should probably behave the same way as adding a view transition pseudo-element after a normal element, e.g. parse but not match anything

@tabatkins
Copy link
Member

Scoped VTs will allow the VT pseudo-els to be used on elements other than the root, so it'll eventually make sense to be able to use them on ::part().

For now, I indeed think that we should allow them to exist but just not match anything.

@dbaron
Copy link
Member Author

dbaron commented Aug 31, 2024

OK, sounds like making no change is the right path here, then.

@dbaron dbaron closed this as not planned Won't fix, can't repro, duplicate, stale Aug 31, 2024
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Sep 6, 2024
@dbaron @chromium-wpt-export-bot
Allow :active-view-transition pseudo-classes after ::part().
6a91342 
Based on the discussion in
w3c/csswg-drafts#10806 and also in
w3c/csswg-drafts#10787, I think the conclusion
from #10806 applies to pseudo-classes as well, and I should reverse my
earlier decision to disallow the :active-view-transition pseudo-classes
after ::part(), even though today it is not possible for them to match.

This makes that change behind the CSSPartAllowsMoreSelectorsAfter flag
(status:experimental), which also contains other related changes.

This matches WebKit's current implementation of those pseudo-classes.

Bug: 40623497
Change-Id: I591fe30bb9e6c3a0953df318919f60dd6962d4a1
Merged
aarongable pushed a commit to chromium/chromium that referenced this issue Sep 6, 2024
@dbaron
Allow :active-view-transition pseudo-classes after ::part().
fc54e78 
Based on the discussion in
w3c/csswg-drafts#10806 and also in
w3c/csswg-drafts#10787, I think the conclusion
from #10806 applies to pseudo-classes as well, and I should reverse my
earlier decision to disallow the :active-view-transition pseudo-classes
after ::part(), even though today it is not possible for them to match.

This makes that change behind the CSSPartAllowsMoreSelectorsAfter flag
(status:experimental), which also contains other related changes.

This matches WebKit's current implementation of those pseudo-classes.

Bug: 40623497
Change-Id: I591fe30bb9e6c3a0953df318919f60dd6962d4a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5839421
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1351997}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Sep 6, 2024
@dbaron @chromium-wpt-export-bot
Allow :active-view-transition pseudo-classes after ::part().
b1fcae1 
Based on the discussion in
w3c/csswg-drafts#10806 and also in
w3c/csswg-drafts#10787, I think the conclusion
from #10806 applies to pseudo-classes as well, and I should reverse my
earlier decision to disallow the :active-view-transition pseudo-classes
after ::part(), even though today it is not possible for them to match.

This makes that change behind the CSSPartAllowsMoreSelectorsAfter flag
(status:experimental), which also contains other related changes.

This matches WebKit's current implementation of those pseudo-classes.

Bug: 40623497
Change-Id: I591fe30bb9e6c3a0953df318919f60dd6962d4a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5839421
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1351997}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Sep 6, 2024
@dbaron @chromium-wpt-export-bot
Allow :active-view-transition pseudo-classes after ::part().
a75813a 
Based on the discussion in
w3c/csswg-drafts#10806 and also in
w3c/csswg-drafts#10787, I think the conclusion
from #10806 applies to pseudo-classes as well, and I should reverse my
earlier decision to disallow the :active-view-transition pseudo-classes
after ::part(), even though today it is not possible for them to match.

This makes that change behind the CSSPartAllowsMoreSelectorsAfter flag
(status:experimental), which also contains other related changes.

This matches WebKit's current implementation of those pseudo-classes.

Bug: 40623497
Change-Id: I591fe30bb9e6c3a0953df318919f60dd6962d4a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5839421
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1351997}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Sep 15, 2024
@dbaron @moz-wptsync-bot
Bug 1917229 [wpt PR 48013] - Allow :active-view-transition pseudo-cla…
b249b21 
…sses after ::part()., a=testonly

Automatic update from web-platform-tests
Allow :active-view-transition pseudo-classes after ::part().

Based on the discussion in
w3c/csswg-drafts#10806 and also in
w3c/csswg-drafts#10787, I think the conclusion
from #10806 applies to pseudo-classes as well, and I should reverse my
earlier decision to disallow the :active-view-transition pseudo-classes
after ::part(), even though today it is not possible for them to match.

This makes that change behind the CSSPartAllowsMoreSelectorsAfter flag
(status:experimental), which also contains other related changes.

This matches WebKit's current implementation of those pseudo-classes.

Bug: 40623497
Change-Id: I591fe30bb9e6c3a0953df318919f60dd6962d4a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5839421
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1351997}

--

wpt-commits: a75813a805d96b9ef5236a2b31fe877967dc881a
wpt-pr: 48013
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Sep 16, 2024
@marco-c
Bug 1917229 [wpt PR 48013] - Allow :active-view-transition pseudo-cla…
d94e01e 
…sses after ::part()., a=testonly

Automatic update from web-platform-tests
Allow :active-view-transition pseudo-classes after ::part().

Based on the discussion in
w3c/csswg-drafts#10806 and also in
w3c/csswg-drafts#10787, I think the conclusion
from #10806 applies to pseudo-classes as well, and I should reverse my
earlier decision to disallow the :active-view-transition pseudo-classes
after ::part(), even though today it is not possible for them to match.

This makes that change behind the CSSPartAllowsMoreSelectorsAfter flag
(status:experimental), which also contains other related changes.

This matches WebKit's current implementation of those pseudo-classes.

Bug: 40623497
Change-Id: I591fe30bb9e6c3a0953df318919f60dd6962d4a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5839421
Reviewed-by: Rune Lillesveen <futharkchromium.org>
Commit-Queue: David Baron <dbaronchromium.org>
Cr-Commit-Position: refs/heads/main{#1351997}

--

wpt-commits: a75813a805d96b9ef5236a2b31fe877967dc881a
wpt-pr: 48013

UltraBlame original commit: c38fc2e2446120b0a73631d83718dc055830e074
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Sep 16, 2024
@marco-c
Bug 1917229 [wpt PR 48013] - Allow :active-view-transition pseudo-cla…
28a9dd3 
…sses after ::part()., a=testonly

Automatic update from web-platform-tests
Allow :active-view-transition pseudo-classes after ::part().

Based on the discussion in
w3c/csswg-drafts#10806 and also in
w3c/csswg-drafts#10787, I think the conclusion
from #10806 applies to pseudo-classes as well, and I should reverse my
earlier decision to disallow the :active-view-transition pseudo-classes
after ::part(), even though today it is not possible for them to match.

This makes that change behind the CSSPartAllowsMoreSelectorsAfter flag
(status:experimental), which also contains other related changes.

This matches WebKit's current implementation of those pseudo-classes.

Bug: 40623497
Change-Id: I591fe30bb9e6c3a0953df318919f60dd6962d4a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5839421
Reviewed-by: Rune Lillesveen <futharkchromium.org>
Commit-Queue: David Baron <dbaronchromium.org>
Cr-Commit-Position: refs/heads/main{#1351997}

--

wpt-commits: a75813a805d96b9ef5236a2b31fe877967dc881a
wpt-pr: 48013

UltraBlame original commit: c38fc2e2446120b0a73631d83718dc055830e074
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Sep 16, 2024
@marco-c
Bug 1917229 [wpt PR 48013] - Allow :active-view-transition pseudo-cla…
6476389 
…sses after ::part()., a=testonly

Automatic update from web-platform-tests
Allow :active-view-transition pseudo-classes after ::part().

Based on the discussion in
w3c/csswg-drafts#10806 and also in
w3c/csswg-drafts#10787, I think the conclusion
from #10806 applies to pseudo-classes as well, and I should reverse my
earlier decision to disallow the :active-view-transition pseudo-classes
after ::part(), even though today it is not possible for them to match.

This makes that change behind the CSSPartAllowsMoreSelectorsAfter flag
(status:experimental), which also contains other related changes.

This matches WebKit's current implementation of those pseudo-classes.

Bug: 40623497
Change-Id: I591fe30bb9e6c3a0953df318919f60dd6962d4a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5839421
Reviewed-by: Rune Lillesveen <futharkchromium.org>
Commit-Queue: David Baron <dbaronchromium.org>
Cr-Commit-Position: refs/heads/main{#1351997}

--

wpt-commits: a75813a805d96b9ef5236a2b31fe877967dc881a
wpt-pr: 48013

UltraBlame original commit: c38fc2e2446120b0a73631d83718dc055830e074
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this issue Sep 16, 2024
@dbaron @moz-wptsync-bot
Bug 1917229 [wpt PR 48013] - Allow :active-view-transition pseudo-cla…
56737c5 
…sses after ::part()., a=testonly

Automatic update from web-platform-tests
Allow :active-view-transition pseudo-classes after ::part().

Based on the discussion in
w3c/csswg-drafts#10806 and also in
w3c/csswg-drafts#10787, I think the conclusion
from #10806 applies to pseudo-classes as well, and I should reverse my
earlier decision to disallow the :active-view-transition pseudo-classes
after ::part(), even though today it is not possible for them to match.

This makes that change behind the CSSPartAllowsMoreSelectorsAfter flag
(status:experimental), which also contains other related changes.

This matches WebKit's current implementation of those pseudo-classes.

Bug: 40623497
Change-Id: I591fe30bb9e6c3a0953df318919f60dd6962d4a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5839421
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1351997}

--

wpt-commits: a75813a805d96b9ef5236a2b31fe877967dc881a
wpt-pr: 48013
jamienicol pushed a commit to jamienicol/gecko that referenced this issue Sep 17, 2024
@dbaron @moz-wptsync-bot
Bug 1917229 [wpt PR 48013] - Allow :active-view-transition pseudo-cla…
6afb3c2 
…sses after ::part()., a=testonly

Automatic update from web-platform-tests
Allow :active-view-transition pseudo-classes after ::part().

Based on the discussion in
w3c/csswg-drafts#10806 and also in
w3c/csswg-drafts#10787, I think the conclusion
from #10806 applies to pseudo-classes as well, and I should reverse my
earlier decision to disallow the :active-view-transition pseudo-classes
after ::part(), even though today it is not possible for them to match.

This makes that change behind the CSSPartAllowsMoreSelectorsAfter flag
(status:experimental), which also contains other related changes.

This matches WebKit's current implementation of those pseudo-classes.

Bug: 40623497
Change-Id: I591fe30bb9e6c3a0953df318919f60dd6962d4a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5839421
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1351997}

--

wpt-commits: a75813a805d96b9ef5236a2b31fe877967dc881a
wpt-pr: 48013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css-shadow-parts-1 css-view-transitions-1 View Transitions; Bugs only
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dbaron @tabatkins @nt1m