-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-color-5] Edge cases for color-mix() percentage serialization questions #10772
Comments
Thanks @weinig both for the suggested wording and also especially for the set of worked examples! |
This is true. Because this section evolved over time, I think that my mental model was whether a number had changed, like Your suggested wording is much better. |
I trust @weinig :) |
Thanks for the writeup and the ping. I looked at the proposed text and existing test cases in color-valid-color-mix-function.html. Am I understanding correctly that the changes would only clarify the existing behavior and not introduce any changes to expected serializations? If that's the case, I'm happy with the new wording. If there are behavior changes in the wording that I missed, could you please point them out? |
Exactly. |
This sounds good to me too fwiw, sorry for the lag. |
The CSSWG will automatically accept this resolution one week from now if no objections are raised here. Anyone can add an emoji to this comment to express support. If you do not support this resolution, please add a new comment. Proposed Resolution: Adopt the |
RESOLVED: Adopt the |
The current text for serializing
color-mix()
states:Directly after that, in example 43, the first example seems to contradict this:
The text states it should use the "un-normalized" values. The value of 60% would only be discovered during the normalization (specifically, step 4)).
So it seems like we need a slightly more complicated serialization rule. The following wording needs work, but I think mostly gets to the intent:
(to make this somewhat easier to grok, below is a pretty comprehensive list of specified value serializations with a comment to the right explaining which rules it is used for each percentage).
The text was updated successfully, but these errors were encountered: