Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-borders][css-backgrounds] Interaction of corner-shape with shape-outside needs to be determined #10747

Open
smfr opened this issue Aug 16, 2024 · 3 comments

Comments

@smfr
Copy link
Contributor

smfr commented Aug 16, 2024

The proposed corner-shape property (#6521, #6980) means that box corners are not always rounded. This will require that https://drafts.csswg.org/css-backgrounds-3/#corner-shaping is updated other describe how to handle non-round corner shapes.

In addition, shape-outside references the <shape-box>, which may also not be a simple rounded rect with non-round corner-shapes. It's not super clear how a scoop corner shape affects the content box, for example.

@bfgeek
Copy link

bfgeek commented Aug 16, 2024

If the use-counters are still low (they might be) it might be another reason to consider removing content-box/padding-box which would mitigate this type of question: #3872

@SebastianZ
Copy link
Contributor

The proposed corner-shape property (#6521, #6980) means that box corners are not always rounded. This will require that https://drafts.csswg.org/css-backgrounds-3/#corner-shaping is updated other describe how to handle non-round corner shapes.

Note that corner-shape is already specified in CSS Borders 4. It still lacks an updated definition of how those shapes are generated. And I am planning to add some spec. text for that.

In addition, shape-outside references the <shape-box>, which may also not be a simple rounded rect with non-round corner-shapes. It's not super clear how a scoop corner shape affects the content box, for example.

The <shape-box> definition there obviously also needs to be adjusted to say that it follows the corner shape defined by border-radius and corner-shape.

Side note: It was resolved to drop notch and scoop for the time being, mainly due to implementation complexity. #6980 advocates to add them back by giving examples where authors would need them.

Sebastian

@smfr
Copy link
Contributor Author

smfr commented Aug 20, 2024

If a UA implements bevel, I think scoop and notch don't add much more complexity. In all cases, there are non-trivial adjustments of the shape of the padding box that are not just a case of adjusting padding box corners based on the size of the corner radius.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants